Re: [patch 3/8] input: ads7846.c sparse lock annotation

[Harvey Harrison <harvey.harrison@gmail.com>]

On Mon, 2008-12-01 at 14:20 -0800, akpm@linux-foundation.org wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 

Small nit with this patch I just noticed (sorry).  It's more
conventional to do the annotation in the other order (was done
late after some other annotations), please apply the following instead:

--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -761,6 +761,8 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
 
 /* Must be called with ts->lock held */
 static void ads7846_disable(struct ads7846 *ts)
+__releases(&ts->lock)
+__acquires(&ts->lock)
 {
 	if (ts->disabled)
 		return;