Re: [PATCH][V7]make get_user_pages interruptible

[Pekka Enberg <penberg@cs.helsinki.fi>]

On Wed, 2008-12-03 at 16:19 +0900, KOSAKI Motohiro wrote:
> > From: Ying Han <yinghan@google.com>
> > 
> > make get_user_pages interruptible
> > The initial implementation of checking TIF_MEMDIE covers the cases of OOM
> > killing. If the process has been OOM killed, the TIF_MEMDIE is set and it
> > return immediately. This patch includes:
> > 
> > 1. add the case that the SIGKILL is sent by user processes. The process can
> > try to get_user_pages() unlimited memory even if a user process has sent a
> > SIGKILL to it(maybe a monitor find the process exceed its memory limit and
> > try to kill it). In the old implementation, the SIGKILL won't be handled
> > until the get_user_pages() returns.
> > 
> > 2. change the return value to be ERESTARTSYS. It makes no sense to return
> > ENOMEM if the get_user_pages returned by getting a SIGKILL signal.
> > Considering the general convention for a system call interrupted by a
> > signal is ERESTARTNOSYS, so the current return value is consistant to that.
> > 
> > Signed-off-by:	Paul Menage <menage@google.com>
> > Signed-off-by:	Ying Han <yinghan@google.com>
> 
> looks good to me.
> 
> 	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Looks good to me too.

Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>