From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 03 Dec 2008 19:00:16 +0000 (GMT) Received: from accolon.hansenpartnership.com ([76.243.235.52]:7656 "EHLO accolon.hansenpartnership.com") by ftp.linux-mips.org with ESMTP id S24084418AbYLCTAH (ORCPT ); Wed, 3 Dec 2008 19:00:07 +0000 Received: from localhost (localhost [127.0.0.1]) by accolon.hansenpartnership.com (Postfix) with ESMTP id C652E9751; Wed, 3 Dec 2008 12:59:56 -0600 (CST) Received: from accolon.hansenpartnership.com ([127.0.0.1]) by localhost (redscar.int.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1v9h3qGUStO; Wed, 3 Dec 2008 12:59:55 -0600 (CST) Received: from [153.66.150.222] (mulgrave-w.int.hansenpartnership.com [153.66.150.222]) by accolon.hansenpartnership.com (Postfix) with ESMTP id 2136380A2; Wed, 3 Dec 2008 12:59:54 -0600 (CST) Subject: Re: [PATCH] SCSI: fix the return type of the remove() method in sgiwd93.c From: James Bottomley To: Kay Sievers Cc: Vorobiev Dmitri , linux-scsi@vger.kernel.org, linux-mips@linux-mips.org, Greg KH In-Reply-To: References: <1227140357-29921-1-git-send-email-dmitri.vorobiev@movial.fi> <46353.88.114.226.209.1228321494.squirrel@webmail.movial.fi> <1228324123.5551.25.camel@localhost.localdomain> <1228327306.5551.36.camel@localhost.localdomain> <35647.88.114.226.209.1228329736.squirrel@webmail.movial.fi> Content-Type: text/plain Date: Wed, 03 Dec 2008 13:00:00 -0600 Message-Id: <1228330800.5551.58.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 21495 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: James.Bottomley@HansenPartnership.com Precedence: bulk X-list: linux-mips On Wed, 2008-12-03 at 19:51 +0100, Kay Sievers wrote: > On Wed, Dec 3, 2008 at 19:42, Vorobiev Dmitri wrote: > >> On Wed, 2008-12-03 at 18:52 +0100, Kay Sievers wrote: > >>> On Wed, Dec 3, 2008 at 18:08, James Bottomley > >>> wrote: > >>> > On Wed, 2008-12-03 at 18:24 +0200, Vorobiev Dmitri wrote: > >>> >> > This patch fixes the following compilation warning: > >>> >> > > >>> >> > CC [M] drivers/scsi/sgiwd93.o > >>> >> > drivers/scsi/sgiwd93.c:314: warning: initialization from > >>> incompatible > >>> >> > pointer type > >>> >> > >>> >> Any news about this one? I think this patch should go via linux-scsi, > >>> >> unless you would be insisting on pushing it via linux-mips, in which > >>> case > >>> >> I'll politely bug Ralf about it. :) > >>> > > >>> > Looks OK for the local change. > >>> > > >>> > Globally, having driver->remove and platform_driver->remove return int > >>> > instead of void looks wrong. Particularly when the only use cases are > >>> > in drivers/base/ and they all ignore the return code. > >>> > > >>> > Greg and Kay ... shouldn't we simply redefine the return values for > >>> the > >>> > remove methods in these structures to return void (and thus match the > >>> > use case)? > >>> > >>> Aren't there many many drivers across the tree, using the "int remove" > >>> version? > >> > >> Yes ... since it's a function prototype. > >> > >> However, if drivers/base simply discards the return, it's a trap we > >> shouldn't be setting. > > > > Hmmm, it does look like the return value is discarded, please see > > drivers/base/dd.c::__device_release_driver() for details. > > > > Does this not deserve a good cleanup? > > Sure, it might be. If you want to patch hundreds of files, send > patches to maintainers, patch drivers you can not even compile, we > could do that. > > We are already in the middle of a ~400 files "struct device" bus_id > conversion, and only very few maintainers respond to these patches. We > also never got any reply to the SCSI bus_id patch we sent weeks ago. > :) When did you send it? Searching the scsi archives on bus_id produces no results, what was the subject line? James