From: Alex Williamson <alex.williamson@hp.com>
To: Keir Fraser <keir.fraser@citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] Fix MMIO UARTs
Date: Wed, 03 Dec 2008 16:24:38 -0700 [thread overview]
Message-ID: <1228346678.7218.28.camel@lappy> (raw)
Change set 982e6fce0e47 added an existence test for UARTs.
Unfortunately, the existence test happens before MMIO UARTs are
ioremapped, therefore it may not be probing where it thinks it's
probing. Rather than moving more code around, I think it's probably
safe to assume the arch code knows what it's doing if it passes in an
MMIO UART.
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
--
diff -r a00eb6595d3c xen/drivers/char/ns16550.c
--- a/xen/drivers/char/ns16550.c Sat Nov 29 09:07:52 2008 +0000
+++ b/xen/drivers/char/ns16550.c Wed Dec 03 16:19:49 2008 -0700
@@ -303,6 +303,14 @@ static int check_existence(struct ns1655
unsigned char status, scratch, scratch2, scratch3;
/*
+ * We can't poke MMIO UARTs until they get I/O remapped later.
+ * Assume that if we're getting MMIO UARTs, the arch code knows
+ * what it's doing.
+ */
+ if (uart->io_base >= 0x10000)
+ return 1;
+
+ /*
* Do a simple existence test first; if we fail this,
* there's no point trying anything else.
*/
reply other threads:[~2008-12-03 23:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228346678.7218.28.camel@lappy \
--to=alex.williamson@hp.com \
--cc=keir.fraser@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.