From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI: handle HARDWARE_ERROR sense correctly
Date: Thu, 04 Dec 2008 15:02:53 -0600 [thread overview]
Message-ID: <1228424573.3363.54.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0812041546260.2180-100000@iolanthe.rowland.org>
On Thu, 2008-12-04 at 15:49 -0500, Alan Stern wrote:
> This patch (as1183) fixes a bug in scsi_check_sense(). The routine is
> documented as returning one of SUCCESS, FAILED, or NEEDS_RETRY. But
> in the HARDWARE_ERROR case it can return ADD_TO_MLQUEUE. And since it
> does this without bothering to increment the retry count, it can lead
> to an infinite retry loop.
>
> The fix is to return NEEDS_RETRY instead. Then the caller,
> scsi_decide_disposition(), will do the right thing.
OK, but why?
The current behaviour is to retry the error until the command timeout
expires, which, I think is what was needed by the annoying arrays that
have retryable hardware errors.
What bug would this patch fix? Because I can see it causing problems
with the arrays that originally reported this problem.
James
next prev parent reply other threads:[~2008-12-04 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 20:49 [PATCH] SCSI: handle HARDWARE_ERROR sense correctly Alan Stern
2008-12-04 21:02 ` James Bottomley [this message]
2008-12-04 21:45 ` Alan Stern
2008-12-04 23:39 ` Mike Anderson
2008-12-08 15:10 ` Alan Stern
2008-12-16 15:27 ` Alan Stern
2008-12-16 19:14 ` James Bottomley
2008-12-16 19:56 ` Alan Stern
2008-12-16 21:49 ` James Bottomley
2008-12-17 15:09 ` Alan Stern
2008-12-05 14:41 ` Kai Makisara
2008-12-05 15:45 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228424573.3363.54.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.