From: Joe Perches <joe@perches.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use vprintk rather that vsnprintf where possible
Date: Thu, 04 Dec 2008 20:21:45 -0800 [thread overview]
Message-ID: <1228450905.13046.51.camel@localhost> (raw)
In-Reply-To: <ac3eb2510812041905j639ea7d4ybe8e83b0d7c5965e@mail.gmail.com>
On Fri, 2008-12-05 at 04:05 +0100, Kay Sievers wrote:
> If we convert to two printk calls for a single line, does that not
> possibly get mixed up with printks from other locations and lead to
> hardly readable log output?
Yes it does.
There are hundreds of possible interleaves in kernel
source today. Adding a couple more isn't horrible.
The changes Matt proposes are good because they make the
kernel image smaller with a very minimal chance of
deciphering difficulty.
Someday there'll be a "multiline_printk_start/end"
mechanism that will avoid interleaving.
next prev parent reply other threads:[~2008-12-05 4:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 20:41 [PATCH] Use vprintk rather that vsnprintf where possible Matt Mackall
2008-12-05 3:05 ` Kay Sievers
2008-12-05 3:13 ` Nick Andrew
2008-12-05 4:08 ` Matt Mackall
2008-12-05 4:21 ` Joe Perches [this message]
2008-12-05 13:49 ` Tilman Schmidt
2008-12-07 8:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228450905.13046.51.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.