From: Mark McLoughlin <markmc@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: "Han, Weidong" <weidong.han@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"Woodhouse, David" <david.woodhouse@intel.com>,
"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>,
"'Jesse Barnes'" <jbarnes@virtuousgeek.org>,
"'iommu@lists.linux-foundation.org'"
<iommu@lists.linux-foundation.org>,
"'Avi Kivity'" <avi@redhat.com>
Subject: Re: [PATCH 08/13] allocation and free functions of virtual machine domain
Date: Fri, 05 Dec 2008 09:20:19 +0000 [thread overview]
Message-ID: <1228468819.3858.7.camel@blaa> (raw)
In-Reply-To: <20081204231706.GO29705@8bytes.org>
Hi Joerg,
On Fri, 2008-12-05 at 00:17 +0100, Joerg Roedel wrote:
> > Again, these new functions are copies of existing code with minor
> > modifications. I'd much rather see the existing code refactored and then
> > modified to handle the DOMAIN_FLAG_VIRTUAL_MACHINE case.
>
> Hey Mark,
>
> can your objections be fixed by follow-up patches bei Han or is anything
> critical in it? My AMD IOMMU patches for KVM support depend on these
> patches and everything they are changed I have to rebase by work. So I
> would prefer if Han can fix the issues found by follow-up patches :)
Well, Weidong is going to have to rebase to dwmw2's tree anyway. I
assume he'll fix at least some of the issues in the process of doing
that.
But you're right in that nothing I pointed out was a complete
showstopper, just ways in which things could be done more cleanly.
Cheers,
Mark.
next prev parent reply other threads:[~2008-12-05 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 14:22 [PATCH 08/13] allocation and free functions of virtual machine domain Han, Weidong
2008-12-04 17:13 ` Mark McLoughlin
2008-12-04 23:17 ` Joerg Roedel
2008-12-05 9:20 ` Mark McLoughlin [this message]
2008-12-05 9:33 ` Han, Weidong
2008-12-05 16:48 ` Avi Kivity
2008-12-05 19:22 ` 'Joerg Roedel'
2008-12-06 2:14 ` Han, Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228468819.3858.7.camel@blaa \
--to=markmc@redhat.com \
--cc=avi@redhat.com \
--cc=david.woodhouse@intel.com \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.