Re: [PATCH 2/2 v4] SGI RTC: add clocksource driver

[john stultz <johnstul@us.ibm.com>]

On Mon, 2008-11-24 at 13:58 -0600, Dimitri Sivanich wrote:
> This patch provides a driver for SGI RTC clocks and timers.
> 
> This provides a high resolution clock and timer source using the SGI
> system-wide synchronized RTC clock/timer hardware.
> 
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> 
> ---
> 
> Changed the shift values for clocksource and clockevent.
> Made other stylistic changes.
> 
[snip]
> +static struct clocksource clocksource_uv = {
> +	.name		= RTC_NAME,
> +	.rating		= 400,
> +	.read		= uv_read_rtc,
> +	.mask		= (cycle_t)UVH_RTC_REAL_TIME_CLOCK_MASK,
> +	.shift		= 10,
> +	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
> +};

Hey Dimitri, 
	Sorry for being slow to catch this. This address my earlier concerns.
Thanks!

Acked-by: John Stultz <johnstul@us.ibm.com>

-john