Re: [PATCH] checkpoint/restart: refuse checkpoint on detached file

[Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

On Thu, 2008-12-04 at 22:41 -0600, Serge E. Hallyn wrote:
> 
> @@ -158,6 +173,12 @@ cr_write_fd_ent(struct cr_ctx *ctx, struct
> files_struct *files, int fd)
>                 goto out;
>         }
> 
> +       /* Make sure this isn't under some detached tree */
> +       if (file_in_detached_tree(file)) {
> +               ret = -EBADF;
> +               goto out;
> +       }

Looks fine to me.  This is racy, though.  Right?

There's no locking to keep the thing mounted for the duration of the
checkpoint.

-- Dave