From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix build of 4xx simple platforms without CONFIG_PCI
Date: Mon, 08 Dec 2008 16:38:14 +1100 [thread overview]
Message-ID: <1228714694.7101.27.camel@pasglop> (raw)
In-Reply-To: <1228714329.23242.52.camel@localhost>
> > --- linux-work.orig/arch/powerpc/platforms/40x/ppc40x_simple.c 2008-12-08 15:51:49.000000000 +1100
> > +++ linux-work/arch/powerpc/platforms/40x/ppc40x_simple.c 2008-12-08 15:51:52.000000000 +1100
> > @@ -61,7 +61,9 @@ static int __init ppc40x_probe(void)
> >
> > for (i = 0; i < ARRAY_SIZE(board); i++) {
> > if (of_flat_dt_is_compatible(root, board[i])) {
> > +#ifdef CONFIG_PCI
> > ppc_pci_flags = PPC_PCI_REASSIGN_ALL_RSRC;
> > +#endif
>
> No! #ifdefs! in C code!
>
> To the tune of you-know-what.
>
> Looks like we need an accessor we can replace with an empty version in
> the !PCI case.
If you have plenty of time on your hands :-) In the meantime, this is a
build fix.
Cheers,
Ben.
next prev parent reply other threads:[~2008-12-08 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 4:53 [PATCH] powerpc: Fix build of 4xx simple platforms without CONFIG_PCI Benjamin Herrenschmidt
2008-12-08 5:32 ` Michael Ellerman
2008-12-08 5:38 ` Benjamin Herrenschmidt [this message]
2008-12-10 14:25 ` Josh Boyer
2008-12-10 19:06 ` Josh Boyer
2008-12-10 21:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228714694.7101.27.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.