From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Date: Mon, 08 Dec 2008 09:06:29 +0000 Subject: Re: [PATCH 1/2] drivers/s390/crypto: Move dereference to after Message-Id: <1228727189.15048.1.camel@localhost> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sun, 2008-12-07 at 23:14 +0100, Julia Lawall wrote: > If reply is ERR_PTR(...), then it should not be dereferenced, so I have > moved the dereference from the declaration to after the IS_ERR test. Nice finding again. That semantic match tools is really useful. Thanks, I'll add the patch to my collection. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/2] drivers/s390/crypto: Move dereference to after IS_ERR test From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com In-Reply-To: References: Content-Type: text/plain Date: Mon, 08 Dec 2008 10:06:29 +0100 Message-Id: <1228727189.15048.1.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Julia Lawall Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: On Sun, 2008-12-07 at 23:14 +0100, Julia Lawall wrote: > If reply is ERR_PTR(...), then it should not be dereferenced, so I have > moved the dereference from the declaration to after the IS_ERR test. Nice finding again. That semantic match tools is really useful. Thanks, I'll add the patch to my collection. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.