From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH 1/4] kvm: qemu: Remove the useless parameter of assigned_dev_update_irq Date: Wed, 10 Dec 2008 10:11:29 +0000 Message-ID: <1228903889.5384.30.camel@blaa> References: <715D42877B251141A38726ABF5CABF2C018BF9ACDF@pdsmsx503.ccr.corp.intel.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "'Avi Kivity'" , "kvm@vger.kernel.org" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59607 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbYLJKM4 (ORCPT ); Wed, 10 Dec 2008 05:12:56 -0500 In-Reply-To: <715D42877B251141A38726ABF5CABF2C018BF9ACDF@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2008-12-10 at 17:44 +0800, Han, Weidong wrote: > Should pass &assigned_dev->dev to ipf_map_irq in while loop. > > Signed-off-by: Weidong Han > --- > qemu/hw/device-assignment.c | 4 ++-- > qemu/hw/pci.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > index 4a38a22..7240158 100644 > --- a/qemu/hw/device-assignment.c > +++ b/qemu/hw/device-assignment.c > @@ -491,7 +491,7 @@ static uint32_t calc_assigned_dev_id(uint8_t bus, uint8_t devfn) > /* The pci config space got updated. Check if irq numbers have changed > * for our devices > */ > -void assigned_dev_update_irq(PCIDevice *d) > +void assigned_dev_update_irq() Yes, but perhaps also rename to update_assigned_device_irqs() ? (i.e. the current name implies that it's an operation on a single assigned device, rather than an operation on all assigned devices) Cheers, Mark.