Re: [PATCH 4/4] [v2] kvm: qemu: Assign irq in init_assigned_device

[Mark McLoughlin <markmc@redhat.com>]

On Wed, 2008-12-10 at 21:23 +0800, Han, Weidong wrote:
> diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
> index 03a52e6..160f001 100644
> --- a/qemu/hw/device-assignment.c
> +++ b/qemu/hw/device-assignment.c
> @@ -499,40 +561,13 @@ void assigned_dev_update_irqs()
>  
>      adev = LIST_FIRST(&adev_head);
>      while (adev) {
> -        AssignedDevInfo *next = LIST_NEXT(adev, next);
...
> +        r = assign_irq(adev);
> +        if (r < 0)
> +            free_assigned_device(adev);
...
> -        adev = next;
> +        adev = LIST_NEXT(adev, next);
>      }
>  }

You're introducing the "use after free" issue here again.

Cheers,
Mark.