From: Ben Hutchings <bhutchings@solarflare.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 7/8] ethtool: Add GGRO and SGRO ops
Date: Fri, 12 Dec 2008 20:11:17 +0000 [thread overview]
Message-ID: <1229112677.3051.9.camel@achroite> (raw)
In-Reply-To: <E1LB0d2-0000rq-Dr@gondolin.me.apana.org.au>
On Fri, 2008-12-12 at 16:31 +1100, Herbert Xu wrote:
> ethtool: Add GGRO and SGRO ops
>
> This patch adds the ethtool ops to enable and disable GRO. It also
> makes GRO depend on RX checksum offload much the same as how TSO
> depends on SG support.
[...]
Why don't you add NETIF_F_GRO to the flags handled by get_flags() and
set_flags()?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-12-12 20:11 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 5:31 [0/8] net: Generic Receive Offload Herbert Xu
2008-12-12 5:31 ` [PATCH 1/8] net: Add frag_list support to skb_segment Herbert Xu
2008-12-12 19:46 ` Evgeniy Polyakov
2008-12-12 21:41 ` Herbert Xu
2008-12-13 2:38 ` Evgeniy Polyakov
2008-12-13 2:43 ` Herbert Xu
2008-12-13 3:11 ` Evgeniy Polyakov
2008-12-13 3:20 ` Herbert Xu
2008-12-12 5:31 ` [PATCH 2/8] net: Add frag_list support to GSO Herbert Xu
2008-12-12 5:31 ` [PATCH 3/8] net: Add Generic Receive Offload infrastructure Herbert Xu
2008-12-12 19:51 ` Evgeniy Polyakov
2008-12-12 21:45 ` Herbert Xu
2008-12-12 22:25 ` Ben Hutchings
2008-12-12 22:56 ` Herbert Xu
2008-12-12 23:11 ` Herbert Xu
2008-12-13 3:43 ` Herbert Xu
2008-12-13 14:03 ` Evgeniy Polyakov
2008-12-12 5:31 ` [PATCH 4/8] ipv4: Add GRO infrastructure Herbert Xu
2008-12-12 22:55 ` Ben Hutchings
2008-12-12 23:04 ` Herbert Xu
2008-12-12 5:31 ` [PATCH 5/8] net: Add skb_gro_receive Herbert Xu
2008-12-12 5:31 ` [PATCH 6/8] tcp: Add GRO support Herbert Xu
2008-12-12 19:56 ` Evgeniy Polyakov
2008-12-12 21:46 ` Herbert Xu
2008-12-13 2:40 ` Evgeniy Polyakov
2008-12-13 2:46 ` Herbert Xu
2008-12-13 3:10 ` Evgeniy Polyakov
2008-12-13 3:19 ` Herbert Xu
2008-12-12 5:31 ` [PATCH 7/8] ethtool: Add GGRO and SGRO ops Herbert Xu
2008-12-12 20:11 ` Ben Hutchings [this message]
2008-12-12 21:48 ` Herbert Xu
2008-12-12 22:35 ` Ben Hutchings
2008-12-12 22:49 ` Herbert Xu
2008-12-14 19:36 ` Waskiewicz Jr, Peter P
2008-12-14 21:09 ` Herbert Xu
2008-12-14 22:00 ` Waskiewicz Jr, Peter P
2008-12-15 3:40 ` Herbert Xu
2008-12-12 5:31 ` [PATCH 8/8] e1000e: Add GRO support Herbert Xu
2008-12-13 1:34 ` [0/8] net: Generic Receive Offload Herbert Xu
2008-12-13 1:35 ` [PATCH 1/8] net: Add frag_list support to skb_segment Herbert Xu
2008-12-16 7:27 ` David Miller
2008-12-13 1:35 ` [PATCH 2/8] net: Add frag_list support to GSO Herbert Xu
2008-12-16 7:30 ` David Miller
2008-12-13 1:35 ` [PATCH 3/8] net: Add Generic Receive Offload infrastructure Herbert Xu
2008-12-15 23:29 ` Paul E. McKenney
2008-12-15 23:39 ` David Miller
2008-12-16 0:02 ` Paul E. McKenney
2008-12-16 2:04 ` Herbert Xu
2008-12-16 16:37 ` Paul E. McKenney
2008-12-16 7:40 ` David Miller
2008-12-13 1:35 ` [PATCH 4/8] ipv4: Add GRO infrastructure Herbert Xu
2008-12-16 7:41 ` David Miller
2008-12-13 1:35 ` [PATCH 5/8] net: Add skb_gro_receive Herbert Xu
2008-12-13 2:52 ` Herbert Xu
2008-12-16 7:42 ` David Miller
2008-12-13 1:35 ` [PATCH 6/8] tcp: Add GRO support Herbert Xu
2008-12-16 7:43 ` David Miller
2008-12-13 1:35 ` [PATCH 7/8] ethtool: Add GGRO and SGRO ops Herbert Xu
2008-12-16 7:44 ` David Miller
2008-12-13 1:35 ` [PATCH 8/8] e1000e: Add GRO support Herbert Xu
2008-12-16 7:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229112677.3051.9.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.