From: Harvey Harrison <harvey.harrison@gmail.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] ieee1394: mark bus_info_data was a __be32 array
Date: Sat, 13 Dec 2008 16:53:11 -0800 [thread overview]
Message-ID: <1229215991.11257.18.camel@brick> (raw)
In-Reply-To: <4944557A.7060902@s5r6.in-berlin.de>
On Sun, 2008-12-14 at 01:38 +0100, Stefan Richter wrote:
> Harvey Harrison wrote:
> > Two access functions get_max_rom and set_hw_config_rom are
> > changed to take __be32 as well. Only bus_info_data was
> > ever passed in so this is OK. All other uses of bus_info_data
> > treated it as a be32 value already.
>
> I pushed the following out to linux1394-2.6.git:
>
> Harvey Harrison (6):
> ieee1394: pcilynx: trivial endian annotation
> ieee1394: replace CSR_SET_BUS_INFO_GENERATION macro
> ieee1394: mark bus_info_data as a __be32 array
> ieee1394: eth1394: trivial sparse annotations
> ieee1394: dv1394 annotate frame input/output structs as little endian
> ieee1934: dv1394: interrupt enabling/disabling broken on big-endian
>
> Note, I dropped two hunks from "mark bus_info_data..." due to another
> change which I posted only a few hours ago. Please check:
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=d88b81b772c6db76eb3b9f9564034f55d0dcdd09
> This interfered with your patch:
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=6b09b72cbdcba8da71b85651eb37e0156aa65def
>
> I pulled your patches into my master branch but not yet into my for-next
> branch (awaiting possible feedback on what I enqueued before your patches).
Looks OK to me, I needed to change the definition of get_max_rom to take
a be32 as it was only ever passed the bus_info_data, now that the other
patch removes that function entirely, the two hunks you dropped are no
longer needed.
Cheers,
Harvey
next prev parent reply other threads:[~2008-12-14 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 23:02 [PATCH 3/4] ieee1394: mark bus_info_data was a __be32 array Harvey Harrison
2008-12-14 0:38 ` Stefan Richter
2008-12-14 0:53 ` Harvey Harrison [this message]
2008-12-14 0:56 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229215991.11257.18.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.