From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH][for 2.6.28] powerpc/fsl-booke: Fix problem with _tlbil_va being interrupted
Date: Sun, 14 Dec 2008 13:46:02 +1100 [thread overview]
Message-ID: <1229222762.26324.19.camel@pasglop> (raw)
In-Reply-To: <1229211183-5350-1-git-send-email-galak@kernel.crashing.org>
On Sat, 2008-12-13 at 17:33 -0600, Kumar Gala wrote:
> An example calling sequence which we did see:
>
> copy_user_highpage -> kmap_atomic -> flush_tlb_page -> _tlbil_va
>
> We got interrupted after setting up the MAS registers before the
> tlbwe and the interrupt handler that caused the interrupt also did
> a kmap_atomic (ide code) and thus on returning from the interrupt
> the MAS registers no longer contained the proper values.
>
> Since we dont save/restore MAS registers for normal interrupts we
> need to disable interrupts in _tlbil_va to ensure atomicity.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Paul, this is a 2.6.28 regression, it should probably go to Linus in
case he hasn't released yet :-)
Cheers,
Ben.
prev parent reply other threads:[~2008-12-14 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 23:33 [PATCH][for 2.6.28] powerpc/fsl-booke: Fix problem with _tlbil_va being interrupted Kumar Gala
2008-12-14 2:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229222762.26324.19.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.