From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Key cache allocation for AP mode
Date: Wed, 17 Dec 2008 12:30:11 +0100 [thread overview]
Message-ID: <1229513411.4566.0.camel@localhost> (raw)
In-Reply-To: <20081217113217.GB18060@jm.kir.nu> (sfid-20081217_123225_574711_95FEDA6B)
On Wed, 2008-12-17 at 13:32 +0200, Jouni Malinen wrote:
> + if (vif->type != NL80211_IFTYPE_AP) {
> + /* Only keyidx 0 should be used with unicast key, but
> + * allow this for client mode for now. */
> + idx = key->keyidx;
Hey, good point, should we make the check in mac80211 stricter as well?
I know we accept non-zero pairwise key idx for some broken pairwise WEP
implementations, but that's only relevant for STA as you note.
johannes
next prev parent reply other threads:[~2008-12-17 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 11:32 [PATCH] ath9k: Key cache allocation for AP mode Jouni Malinen
2008-12-17 11:30 ` Johannes Berg [this message]
2008-12-17 12:05 ` Jouni Malinen
2008-12-17 12:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229513411.4566.0.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.