From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" Subject: Re: pv_ops dom0 x86_32 PAE kernel buildlog of missingsymbols... Date: Wed, 17 Dec 2008 16:49:07 +0100 Message-ID: <1229528947.7033.16.camel@marc> References: <49402FA9.80403@wol.de> <1228996810.19933.48.camel@zakaz.uk.xensource.com> <4941216C.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4941216C.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org Hello Jan, hello Ian, i did another build today (c/s 2239) and can confirm that only the following two warnings are left: ERROR: "blk_put_queue" [drivers/xen/blkback/blkbk.ko] undefined! ERROR: "blk_get_queue" [drivers/xen/blkback/blkbk.ko] undefined! Should i give Jan's patch a try or is another patch to address this errors planed to be added to the patchset soon? I ask this because i have some spare time and hardware over the weekend i could use to do some boot tests. Maybe i can provide some valuable logs then... Marc Am Donnerstag, den 11.12.2008, 13:19 +0000 schrieb Jan Beulich: > >>> Ian Campbell 11.12.08 13:00 >>> > >ERROR: "alloc_empty_pages_and_pagevec" [drivers/xen/blkback/blkbk.ko] > >undefined! > >ERROR: "blk_put_queue" [drivers/xen/blkback/blkbk.ko] undefined! > >ERROR: "free_empty_pages_and_pagevec" [drivers/xen/blkback/blkbk.ko] undefined! > >ERROR: "blk_get_queue" [drivers/xen/blkback/blkbk.ko] undefined! > >ERROR: "set_phys_to_machine" [drivers/xen/blkback/blkbk.ko] undefined! > > > >The *_empty_pages_and_pagevec and set_phys_to_machine are probably fair > >game for an EXPORT_SYMBOL_GPL. The two blk subsystem ones are > >suspicious, the fact that they aren't already exported suggests there is > >another API we should be using. > > I'd be curious if you can find one - in our 2.6.25 merge patch the only way > to address this was to open-code what they do in blkback (short of re-adding > the exports): > > --- head-2008-12-08.orig/drivers/xen/blkback/blkback.c 2008-12-08 13:24:54.000000000 +0100 > +++ head-2008-12-08/drivers/xen/blkback/blkback.c 2008-12-08 13:24:57.000000000 +0100 > @@ -148,7 +148,7 @@ static void unplug_queue(blkif_t *blkif) > return; > if (blkif->plug->unplug_fn) > blkif->plug->unplug_fn(blkif->plug); > - blk_put_queue(blkif->plug); > + kobject_put(&blkif->plug->kobj); > blkif->plug = NULL; > } > > @@ -159,7 +159,8 @@ static void plug_queue(blkif_t *blkif, s > if (q == blkif->plug) > return; > unplug_queue(blkif); > - blk_get_queue(q); > + WARN_ON(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)); > + kobject_get(&q->kobj); > blkif->plug = q; > } > > > Jan