From: Eric Paris <eparis@redhat.com>
To: Frederik Deweerdt <frederik.deweerdt@xprog.eu>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kosaki.motohiro@jp.fujitsu.com, hch@infradead.org
Subject: Re: [PATCH] sys_execve and sys_uselib do not call into fsnotify
Date: Wed, 17 Dec 2008 14:22:21 -0500 [thread overview]
Message-ID: <1229541741.3384.48.camel@localhost.localdomain> (raw)
In-Reply-To: <20081217190433.GA31115@gambetta>
On Wed, 2008-12-17 at 20:04 +0100, Frederik Deweerdt wrote:
> Hello Eric,
>
> On Wed, Dec 17, 2008 at 01:53:20PM -0500, Eric Paris wrote:
> > sys_execve and sys_uselib do not call into fsnotify so inotify does not get
> > open events for these types of syscalls. This patch simply makes the
> > requisite fsnotify calls.
>
> Just curious, isn't the fact that the open still may fail a problem?
> For example, if the lib is not executable in sys_uselib or if the file
> was denied write access in open_exec.
I could be convinced to change it but like what I have. At this point
the file is open. If it fails after this we are going to call fput()
which calls __fput() which calls fsnotify_close(). Seemed odd to leave
a close without an open (although that's what we have today.)
This doesn't mean the syscall was successful, but the file was opened,
and it will be closed....
-Eric
next prev parent reply other threads:[~2008-12-17 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 18:53 [PATCH] sys_execve and sys_uselib do not call into fsnotify Eric Paris
2008-12-17 19:04 ` Frederik Deweerdt
2008-12-17 19:22 ` Eric Paris [this message]
2008-12-17 22:52 ` Frederik Deweerdt
2008-12-17 23:03 ` Andrew Morton
2008-12-18 2:39 ` KOSAKI Motohiro
2008-12-18 2:32 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229541741.3384.48.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=frederik.deweerdt@xprog.eu \
--cc=hch@infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.