All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Johann Felix Soden <johfel@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 1/4] driver core: fix using 'ret' variable in unregister_dynamic_debug_module
Date: Wed, 17 Dec 2008 11:28:20 -0800	[thread overview]
Message-ID: <1229542103-24678-1-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20081217192737.GA24641@kroah.com>

From: Johann Felix Soden <johfel@users.sourceforge.net>

The 'ret' variable is assigned, but not used in the return statement. Fix this.

Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
Acked-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/dynamic_printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d83660f..d0fd0e4 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
 	nr_entries--;
 out:
 	up(&debug_list_mutex);
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
 
-- 
1.6.0.4


  reply	other threads:[~2008-12-17 19:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 19:27 [GIT PATCH] driver core fixes for your 2.6-git tree Greg KH
2008-12-17 19:28 ` Greg Kroah-Hartman [this message]
2008-12-17 19:28 ` [PATCH 2/4] xilinx_hwicap: remove improper wording in license statement Greg Kroah-Hartman
2008-12-17 23:08   ` Alan Cox
2008-12-17 23:45     ` Greg KH
2008-12-17 19:28 ` [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages Greg Kroah-Hartman
2008-12-17 19:28 ` [PATCH 4/4] STAGING: Move staging drivers back to staging-specific menu Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229542103-24678-1-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=johfel@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.