From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbYLQTao (ORCPT ); Wed, 17 Dec 2008 14:30:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751511AbYLQT3R (ORCPT ); Wed, 17 Dec 2008 14:29:17 -0500 Received: from kroah.org ([198.145.64.141]:54239 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751632AbYLQT3P (ORCPT ); Wed, 17 Dec 2008 14:29:15 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Marcel Holtmann , Greg Kroah-Hartman Subject: [PATCH 3/4] driver core: add newlines to debugging enabled/disabled messages Date: Wed, 17 Dec 2008 11:28:22 -0800 Message-Id: <1229542103-24678-3-git-send-email-gregkh@suse.de> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <20081217192737.GA24641@kroah.com> References: <20081217192737.GA24641@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcel Holtmann Both messages are missing the newline and thus dmesg output gets scrambled. Signed-off-by: Marcel Holtmann Signed-off-by: Greg Kroah-Hartman --- lib/dynamic_printk.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c index d0fd0e4..8e30295 100644 --- a/lib/dynamic_printk.c +++ b/lib/dynamic_printk.c @@ -289,7 +289,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf, dynamic_enabled = DYNAMIC_ENABLED_SOME; err = 0; printk(KERN_DEBUG - "debugging enabled for module %s", + "debugging enabled for module %s\n", elem->name); } else if (!value && (elem->enable == 1)) { elem->enable = 0; @@ -309,7 +309,7 @@ static ssize_t pr_debug_write(struct file *file, const char __user *buf, err = 0; printk(KERN_DEBUG "debugging disabled for module " - "%s", elem->name); + "%s\n", elem->name); } } } -- 1.6.0.4