Re: [PATCH] net: Fix module refcount leak in kernel_accept()

[Marcel Holtmann <marcel@holtmann.org>]

Hi Wei,

> The kernel_accept() does not hold the module refcount of newsock->ops->owner,
> so we need __module_get(newsock->ops->owner) code after call kernel_accept()
> by hand.
> In sunrpc, the module refcount is missing to hold. So this cause kernel panic.
> 
> Used following script to reproduct:
> 
> while [ 1 ];
> do
>     mount -t nfs4 192.168.0.19:/ /mnt
>     touch /mnt/file
>     umount /mnt
>     lsmod | grep ipv6
> done
> 
> This patch fixed the problem by add __module_get(newsock->ops->owner) to
> kernel_accept(). So we do not need to used __module_get(newsock->ops->owner)
> in every place when used kernel_accept().
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
>  net/bluetooth/rfcomm/core.c |    2 --
>  net/socket.c                |    1 +
>  2 files changed, 1 insertions(+), 2 deletions(-)

I was just about to reply and ask you to double check the users since I
know that I am using that API. Hey, but you already did that. Thanks.

Dave, for what its worth, Acked-by me.

Regards

Marcel