From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Schwidefsky Date: Mon, 22 Dec 2008 08:44:54 +0000 Subject: Re: [PATCH 1/13] s390: Remove redundant test Message-Id: <1229935495.1529.9.camel@localhost> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sun, 2008-12-21 at 16:28 +0100, Julia Lawall wrote: > The loop above the modified code only terminates when rc is a valid pointer. > > A simplified version of the semantic patch that makes this change is as > follows: (http://www.emn.fr/x-info/coccinelle/) Purely cosmetic but simplifies the code. So yes, makes sense. Added to the s390 patch queue. Thanks Julia. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/13] s390: Remove redundant test From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com In-Reply-To: References: Content-Type: text/plain Date: Mon, 22 Dec 2008 09:44:54 +0100 Message-Id: <1229935495.1529.9.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Julia Lawall Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: On Sun, 2008-12-21 at 16:28 +0100, Julia Lawall wrote: > The loop above the modified code only terminates when rc is a valid pointer. > > A simplified version of the semantic patch that makes this change is as > follows: (http://www.emn.fr/x-info/coccinelle/) Purely cosmetic but simplifies the code. So yes, makes sense. Added to the s390 patch queue. Thanks Julia. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.