From: Thomas Zimmermann <tzimmermann@suse.de>
To: neil.armstrong@linaro.org, jessica.zhang@oss.qualcomm.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes
Date: Mon, 18 Aug 2025 11:01:23 +0200 [thread overview]
Message-ID: <122a2a73-8d9d-4dfd-b747-e445a1ac685a@suse.de> (raw)
In-Reply-To: <20250812082509.227879-1-tzimmermann@suse.de>
ping for review
Am 12.08.25 um 10:25 schrieb Thomas Zimmermann:
> Include <linux/property.h> to declare device_property_read_bool() and
> <linux/mod_devicetable.h> to declare struct of_device_id. Avoids the
> dependency on the backlight header to include both.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> index e91f50662997..7e2f4e043d62 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> @@ -7,7 +7,9 @@
> #include <linux/backlight.h>
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> +#include <linux/property.h>
> #include <linux/regulator/consumer.h>
>
> #include <video/mipi_display.h>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2025-08-18 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:25 [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes Thomas Zimmermann
2025-08-18 9:01 ` Thomas Zimmermann [this message]
2025-08-18 16:19 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=122a2a73-8d9d-4dfd-b747-e445a1ac685a@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.