From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LGTuT-0007Au-Op for mharc-grub-devel@gnu.org; Sat, 27 Dec 2008 02:48:33 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LGTuR-0007AR-0Y for grub-devel@gnu.org; Sat, 27 Dec 2008 02:48:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LGTuP-0007AF-GM for grub-devel@gnu.org; Sat, 27 Dec 2008 02:48:30 -0500 Received: from [199.232.76.173] (port=46304 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LGTuP-0007AC-C1 for grub-devel@gnu.org; Sat, 27 Dec 2008 02:48:29 -0500 Received: from c60.cesmail.net ([216.154.195.49]:53086) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LGTuO-0006L5-RE for grub-devel@gnu.org; Sat, 27 Dec 2008 02:48:29 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 27 Dec 2008 02:48:26 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 9E5D534C6D for ; Sat, 27 Dec 2008 02:58:20 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <87wsdmu2bx.fsf_-_@jidanni.org> References: <87k5c9h7dq.fsf@jidanni.org> <87wsdmu2bx.fsf_-_@jidanni.org> Content-Type: text/plain Date: Sat, 27 Dec 2008 02:48:25 -0500 Message-Id: <1230364105.2633.61.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-3.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] grub-install message should mention --recheck X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Dec 2008 07:48:31 -0000 On Sat, 2008-12-27 at 04:08 +0800, jidanni@jidanni.org wrote: > *** grub-installORIG.in 2008-12-27 02:43:09.000000000 +0800 > --- grub-install.in 2008-12-27 04:06:02.000000000 +0800 > *************** > *** 304,310 **** > # Prompt the user to check if the device map is correct. > ! echo "Installation finished. No error reported." > ! echo "This is the contents of the device map $device_map." > ! echo "Check if this is correct or not. If any of the lines is incorrect," > ! echo "fix it and re-run the script \`grub-install'." > ! echo > > --- 304,310 ---- > # Prompt the user to check if the device map is correct. > ! cat < ! Installation finished. No error reported. These are the contents of > ! the device map $device_map. If any of the lines are incorrect, fix it > ! and/or re-run grub-install [--recheck]. > ! EOF Actually, grub-install should not dump the whole device.map to the screen. It should only show the entries that it actually used during the installation. If no device.map entries were used (which is true in 99% cases, I guess), there should be no message at all. I'm not against mentioning "grub-install --recheck", although I'd like to see comment from the users of cross-device setups where device.map is actually used. They should know better if grub-install --recheck" does the right thing or grossly discards their manually crafted device.map files. If the later is true, maybe it's better to keep the current message. > -- Regards, Pavel Roskin