All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Klimov <klimov.linux@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: video4linux-list@redhat.com
Subject: [PATCH] gspca: fix codingstyle in sd_mod_init
Date: Thu, 01 Jan 2009 10:53:48 +0300	[thread overview]
Message-ID: <1230796428.5124.15.camel@tux.localhost> (raw)

Hello, Jean-Francois
What do you think about this patch ?

Fix CodingStyle in sd_mod_init function in all gspca drivers.
Introduce int ret and check it value after call to usb_register().


Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

---
diff -r b9092fca16f0 linux/drivers/media/video/gspca/conex.c
--- a/linux/drivers/media/video/gspca/conex.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/conex.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1028,7 +1028,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/etoms.c
--- a/linux/drivers/media/video/gspca/etoms.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/etoms.c	Thu Jan 01 10:45:02 2009 +0300
@@ -933,7 +933,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/finepix.c
--- a/linux/drivers/media/video/gspca/finepix.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/finepix.c	Thu Jan 01 10:45:02 2009 +0300
@@ -454,7 +454,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/m5602/m5602_core.c
--- a/linux/drivers/media/video/gspca/m5602/m5602_core.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/m5602/m5602_core.c	Thu Jan 01 10:45:02 2009 +0300
@@ -373,7 +373,9 @@
 /* -- module insert / remove -- */
 static int __init mod_m5602_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/mars.c
--- a/linux/drivers/media/video/gspca/mars.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/mars.c	Thu Jan 01 10:45:02 2009 +0300
@@ -420,7 +420,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/ov519.c
--- a/linux/drivers/media/video/gspca/ov519.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/ov519.c	Thu Jan 01 10:45:02 2009 +0300
@@ -2201,7 +2201,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/ov534.c
--- a/linux/drivers/media/video/gspca/ov534.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/ov534.c	Thu Jan 01 10:45:02 2009 +0300
@@ -584,7 +584,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/pac207.c
--- a/linux/drivers/media/video/gspca/pac207.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/pac207.c	Thu Jan 01 10:45:02 2009 +0300
@@ -564,7 +564,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/pac7311.c
--- a/linux/drivers/media/video/gspca/pac7311.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/pac7311.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1110,7 +1110,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sonixb.c
--- a/linux/drivers/media/video/gspca/sonixb.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/sonixb.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1301,7 +1301,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sonixj.c
--- a/linux/drivers/media/video/gspca/sonixj.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/sonixj.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1809,7 +1809,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	info("registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca500.c
--- a/linux/drivers/media/video/gspca/spca500.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca500.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1109,7 +1109,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca501.c
--- a/linux/drivers/media/video/gspca/spca501.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca501.c	Thu Jan 01 10:45:02 2009 +0300
@@ -2258,7 +2258,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca505.c
--- a/linux/drivers/media/video/gspca/spca505.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca505.c	Thu Jan 01 10:45:02 2009 +0300
@@ -931,7 +931,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca506.c
--- a/linux/drivers/media/video/gspca/spca506.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca506.c	Thu Jan 01 10:45:02 2009 +0300
@@ -771,7 +771,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca508.c
--- a/linux/drivers/media/video/gspca/spca508.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca508.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1703,7 +1703,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/spca561.c
--- a/linux/drivers/media/video/gspca/spca561.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/spca561.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1203,7 +1203,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/stk014.c
--- a/linux/drivers/media/video/gspca/stk014.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/stk014.c	Thu Jan 01 10:45:02 2009 +0300
@@ -560,7 +560,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	info("registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/stv06xx/stv06xx.c
--- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c	Thu Jan 01 10:45:02 2009 +0300
@@ -500,7 +500,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/sunplus.c
--- a/linux/drivers/media/video/gspca/sunplus.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/sunplus.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1495,7 +1495,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/t613.c
--- a/linux/drivers/media/video/gspca/t613.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/t613.c	Thu Jan 01 10:45:02 2009 +0300
@@ -1175,7 +1175,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/tv8532.c
--- a/linux/drivers/media/video/gspca/tv8532.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/tv8532.c	Thu Jan 01 10:45:02 2009 +0300
@@ -578,7 +578,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/vc032x.c
--- a/linux/drivers/media/video/gspca/vc032x.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/vc032x.c	Thu Jan 01 10:45:02 2009 +0300
@@ -2485,7 +2485,9 @@
 /* -- module insert / remove -- */
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;
diff -r b9092fca16f0 linux/drivers/media/video/gspca/zc3xx.c
--- a/linux/drivers/media/video/gspca/zc3xx.c	Thu Jan 01 10:41:53 2009 +0300
+++ b/linux/drivers/media/video/gspca/zc3xx.c	Thu Jan 01 10:45:02 2009 +0300
@@ -7608,7 +7608,9 @@
 
 static int __init sd_mod_init(void)
 {
-	if (usb_register(&sd_driver) < 0)
+	int ret;
+	ret = usb_register(&sd_driver);
+	if (ret < 0)
 		return -1;
 	PDEBUG(D_PROBE, "registered");
 	return 0;


-- 
Best regards, Klimov Alexey

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

                 reply	other threads:[~2009-01-01  7:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230796428.5124.15.camel@tux.localhost \
    --to=klimov.linux@gmail.com \
    --cc=moinejf@free.fr \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.