From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix build errors of extent_io.c
Date: Mon, 05 Jan 2009 12:39:20 -0500 [thread overview]
Message-ID: <1231177160.4290.139.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20090105173734.GA32436@infradead.org>
On Mon, 2009-01-05 at 12:37 -0500, Christoph Hellwig wrote:
> On Tue, Jan 06, 2009 at 02:29:17AM +0900, Ryusuke Konishi wrote:
> > 2009/1/6 Chris Mason <chris.mason@oracle.com>:
> > > On Wed, 2008-12-24 at 17:56 +0900, Ryusuke Konishi wrote:
> > >> Hi Chris,
> > >>
> > >> I've started to read and try btrfs, and soon met the following build
> > >> errors. The attached patch fixes the problem.
> > >>
> > >> Could you check this?
> > >>
> > >
> > > Strange, I wonder why your gcc complains and mine doesn't ;) I'll fix
> > > these up thouhg.
> >
> > Because I tried it on a powerpc ;)
> > The check of EXPORT_SYMBOL macros seems to be more strict
> > than that of x86.
>
> It doesn't really matter how strict the checks are, because the exports
> simply need to go away. As long as the extent_map/buffer code resides
> inside btrfs no one should be using it without either copying it or
> moving it out of the btrfs module and into a common one first.
Yes, my plan was to drop the exports.
-chris
next prev parent reply other threads:[~2009-01-05 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 8:56 [PATCH] Btrfs: fix build errors of extent_io.c Ryusuke Konishi
2009-01-05 15:47 ` Chris Mason
2009-01-05 17:29 ` Ryusuke Konishi
2009-01-05 17:37 ` Christoph Hellwig
2009-01-05 17:39 ` Chris Mason [this message]
2009-01-05 17:48 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231177160.4290.139.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.