All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nicolas Pitre <nico@cam.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: powerpc: introduce asm/swab.h
Date: Wed, 07 Jan 2009 17:05:30 +1100	[thread overview]
Message-ID: <1231308330.14860.78.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.0901062122100.3057@localhost.localdomain>


> Ok, I committed it as a quick-fix. I'm not sure that is necessarily the 
> final one, but at least it is better than not compiling.
> 
> For example, it's kind of silly to use two __fswab32()'s with other 
> oddness if that one just falls back on __constant_swab32: maybe we'd want 
> to make sure that we'd use ___constant_swab64() in that case, and only do 
> the whole __SWAB_64_THRU_32__ if we really have a __arch_swab32() 
> function.
> 
> Of course, I do hope that anybody who #defines __SWAB_64_THRU_32__ already 
> has that __arch_swab32() thing, so it's likely fine.
> 
> I also wonder whether gcc generates better code with a union than with 
> that 64-bit math...

Allright, it boots here on a powerbook, though IDE seems to be
busticated (it gets lost interrupts trying to enable DMA, though it does
fallback properly to PIO), but I think that's unrelated. I'll have a
closer look tomorrow.

Cheers,
Ben.



  parent reply	other threads:[~2009-01-07  6:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200901070400.n0740Ore002063@hera.kernel.org>
2009-01-07  4:42 ` powerpc: introduce asm/swab.h Benjamin Herrenschmidt
2009-01-07  4:48   ` Harvey Harrison
2009-01-07  4:59     ` Nicolas Pitre
2009-01-07  5:08       ` Linus Torvalds
2009-01-07  5:12         ` Nicolas Pitre
2009-01-07  5:01   ` Linus Torvalds
2009-01-07  5:08     ` Nicolas Pitre
2009-01-07  5:02   ` Benjamin Herrenschmidt
2009-01-07  5:11     ` Linus Torvalds
2009-01-07  5:19       ` Nicolas Pitre
2009-01-07  5:26         ` Nicolas Pitre
2009-01-07  5:38           ` Linus Torvalds
2009-01-07  5:37         ` Linus Torvalds
2009-01-07  6:02           ` Harvey Harrison
2009-01-07  6:05           ` Benjamin Herrenschmidt [this message]
2009-01-07  5:39       ` Steven Rostedt
2009-01-07  5:43       ` Benjamin Herrenschmidt
2009-01-07  8:37   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231308330.14860.78.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bzolnier@gmail.com \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.