All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlef Riekenberg <wine.dev@web.de>
To: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, trivial@kernel.org
Subject: [PATCH] [TRIVIAL] linux/types.h: Don't depend on __GNUC__ for __le64 / __be64 [synced to git]
Date: Wed, 07 Jan 2009 10:29:18 +0100	[thread overview]
Message-ID: <1231320558.5547.21.camel@p4.lan> (raw)
In-Reply-To: <1231029623.7225.10.camel@p4.lan>

Hi.
<linux/cdrom.h> is used in Wine, but failed to compile with pcc.
(__le64 and __be64 are referenced in <linux/byteorder/little_endian.h>)

There is no reason to restrict the typedefs to __GNUC__.
This Patch is trivial for gcc and icc, but required for other compiler.

As reference, the typedefs for __u64 and __s64 where fixed to be
available for other compiler on 02. Mai 2008 by H. Peter Anvin
(commit edfa5cfa3dc5bfa95e6aa82a2b8904e7f6c35ed7)

Wine: http://www.winehq.org
pcc:  http://pcc.ludd.ltu.se

This patch is again a resync to current git.
Is there anything, that I can do for this Patch?

Please CC me personally. Thanks

-- 
Bye bye ... Detlef



>From ce469182d86b94e4e2fd4c84028369a2eefdfb0c Mon Sep 17 00:00:00 2001
From: Detlef Riekenberg <wine.dev@web.de>
Date: Wed, 7 Jan 2009 10:11:44 +0100
Subject: [PATCH] linux/types.h: Don't depend on __GNUC__ for
__le64/__be64

Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
---
 include/linux/types.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/types.h b/include/linux/types.h
index 3b864f2..712ca53 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -176,10 +176,9 @@ typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
 typedef __u32 __bitwise __le32;
 typedef __u32 __bitwise __be32;
-#if defined(__GNUC__)
 typedef __u64 __bitwise __le64;
 typedef __u64 __bitwise __be64;
-#endif
+
 typedef __u16 __bitwise __sum16;
 typedef __u32 __bitwise __wsum;
 
-- 
1.5.4.3





  reply	other threads:[~2009-01-07  9:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29 23:55 [PATCH] linux/types.h: Do not depend on __GNUC__ for __le64 and __be64 Detlef Riekenberg
2008-12-30  0:04 ` H. Peter Anvin
2009-01-04  0:40 ` [PATCH] linux/types.h: Do not depend on __GNUC__ for __le64 and __be64 [synced to git] Detlef Riekenberg
2009-01-07  9:29   ` Detlef Riekenberg [this message]
2009-01-07 19:21     ` [PATCH] [TRIVIAL] linux/types.h: Don't depend on __GNUC__ for __le64 / " H. Peter Anvin
2009-01-07 19:35       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231320558.5547.21.camel@p4.lan \
    --to=wine.dev@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.