From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "Kashyap, Desai" <kashyap.desai@lsi.com>,
linux-scsi@vger.kernel.org, eric.moore@lsi.com,
sathya.prakash@lsi.com
Subject: Re: [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch]
Date: Thu, 08 Jan 2009 09:00:31 -0600 [thread overview]
Message-ID: <1231426831.3237.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20090108145303.GA6936@parisc-linux.org>
On Thu, 2009-01-08 at 07:53 -0700, Matthew Wilcox wrote:
> On Thu, Jan 08, 2009 at 02:27:16PM +0530, Kashyap, Desai wrote:
> > Added support for MSI enable/disable for different buses FC,SPI,SAS instead
> > of having single MSI enable/disable feature.
>
> Why do you think you need this?
>
> Either the system supports MSI or it doesn't. The original reason for
> only enabling MSI on SPI cards was that it reduced the number of bug
> reports since FC and SAS cards are likely to be used on machines with
> functional MSI.
>
> This is of course a horrible hack. The right thing to do is to detect
> that you've never received an interrupt, disable MSI, enable regular
> interrupts and try again.
Right ... we actually had agreement on this and a set of patches to
implement some of it that went via the PCI list ... I'll see if I can
find them.
James
prev parent reply other threads:[~2009-01-08 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 8:57 [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch] Kashyap, Desai
2009-01-08 14:53 ` Matthew Wilcox
2009-01-08 15:00 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231426831.3237.3.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=eric.moore@lsi.com \
--cc=kashyap.desai@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sathya.prakash@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.