From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Karen Xie <kxie@chelsio.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
erezzi.list@gmail.com
Subject: Re: [PATCH] iscsi_tcp - make padbuf non-static
Date: Sat, 10 Jan 2009 12:53:46 -0600 [thread overview]
Message-ID: <1231613626.3642.44.camel@localhost.localdomain> (raw)
In-Reply-To: <49666ADF.1020703@cs.wisc.edu>
On Thu, 2009-01-08 at 15:06 -0600, Mike Christie wrote:
> Karen Xie wrote:
> > [PATCH] iscsi_tcp - make padbuf non-static
> >
> > From: Karen Xie <kxie@chelsio.com>
> >
> > virt_to_page() call should not be used on kernel text and data addresses.
> > virt_to_page() is used by sg_init_one(). So change padbuf to be allocated within iscsi_segment.
> >
> > Signed-off-by: Karen Xie <kxie@chelsio.com>
>
>
> Thanks for finding this.
>
> Acked-by: Mike Christie <michaelc@cs.wisc.edu>
Could one of you regenerate this against current git head, please, it
seems to have suffered from the iscsi to libiscsi move.
James
prev parent reply other threads:[~2009-01-10 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:58 [PATCH] iscsi_tcp - make padbuf non-static Karen Xie
2009-01-08 21:06 ` Mike Christie
2009-01-10 18:53 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231613626.3642.44.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=erezzi.list@gmail.com \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.