All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Silverstone <dsilvers@simtec.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
	linux-input@vger.kernel.org, vince@simtec.co.uk
Subject: Re: usbtouchscreen: Add support for Zytronic capacitive touchscreen
Date: Mon, 12 Jan 2009 09:07:14 +0000	[thread overview]
Message-ID: <1231751234.23618.6.camel@petitemort> (raw)
In-Reply-To: <20090111234903.ZZRA012@mailhub.coreip.homeip.net>

> > Index: linux.git/drivers/input/touchscreen/usbtouchscreen.c
> > +	/* Always service the USB devices irq not just when the input device is
> > +	 * open.
> > +	 */
> > +	int irq_always;
> > +
> Why is this needed?

Some devices (E.g. specifically this one) expect their interrupt
endpoints to always be serviced. In this case, the device has an
on-board watchdog and will reboot (disconnect and reconnecting to the
USB) if it is not serviced in a timely fashion.


> > +	case 0xC0: /* down */
> > +		dev->x = (pkt[1] & 0x7f) | ((pkt[2] & 0x07) << 7);
> > +		dev->y = (pkt[3] & 0x7f) | ((pkt[4] & 0x07) << 7);
> > +		dev->touch = 1;
> > +		dev->press = 1;
> Since the device does not report real pressure readings don't try to
> fake it, reporting touch is enough.

I believe that this is because some userland libraries, particularly
tslib, require the pressure reading in order to believe the device is
functioning usefully. Specifically, consider plugins/input-raw of
tslib's source package which uses pressure rather than touch.

Regards,

Daniel.

-- 
Daniel Silverstone                              http://www.simtec.co.uk/
PGP mail accepted and encouraged.            Key Id: 2BC8 4016 2068 7895



  reply	other threads:[~2009-01-12  9:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09 12:10 usbtouchscreen: Add support for Zytronic capacitive touchscreen Ben Dooks
2009-01-12  7:53 ` Dmitry Torokhov
2009-01-12  9:07   ` Daniel Silverstone [this message]
2009-01-13  5:33     ` Dmitry Torokhov
2009-01-13  9:29       ` Daniel Silverstone
2009-01-14  5:35         ` Dmitry Torokhov
2009-01-14 17:36           ` Daniel Silverstone
2009-01-15 15:12             ` Ben Dooks
2009-01-29 10:55               ` Daniel Silverstone
2009-03-31  9:52                 ` Daniel Silverstone
2009-04-08 20:33                   ` Dmitry Torokhov
2009-04-09  8:20                     ` Daniel Silverstone
  -- strict thread matches above, loose matches on Subject: below --
2009-11-23 14:39 Ben Dooks
2009-11-23 17:21 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231751234.23618.6.camel@petitemort \
    --to=dsilvers@simtec.co.uk \
    --cc=ben-linux@fluff.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.