From: Ben Hutchings <bhutchings@solarflare.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
"Neil Horman" <nhorman@tuxdriver.com>,
shemminger@vyatta.com, netdev@vger.kernel.org,
"Krzysztof Hałasa" <khc@pm.waw.pl>
Subject: Re: [PATCH] net: Remove redundant NAPI functions
Date: Mon, 12 Jan 2009 14:09:50 +0000 [thread overview]
Message-ID: <1231769390.3075.2.camel@achroite> (raw)
In-Reply-To: <20090112071317.GA4212@ff.dom.local>
On Mon, 2009-01-12 at 07:13 +0000, Jarek Poplawski wrote:
> On Thu, Jan 08, 2009 at 08:30:10PM +0000, Ben Hutchings wrote:
> > Following the removal of the unused struct net_device * parameter from
> > the NAPI functions named *netif_rx_* in commit 908a7a1, they are
> > exactly equivalent to the corresponding *napi_* functions and are
> > therefore redundant.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> ...
>
> Alas I wasn't able to send this earlier, but here is some issue
> (I see Krzysztof tried to patch this too):
>
> > diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
> > index 2dc2416..9ea167b 100644
> > --- a/drivers/net/wan/ixp4xx_hss.c
> > +++ b/drivers/net/wan/ixp4xx_hss.c
[...]
What's the issue - does it conflict with another change to this file?
> Plus a missing chunk for: drivers/staging/benet/be_int.c.
That didn't go in via net-next-2.6.
Since the merge window is closed I assume this will now be deferred to
2.6.30.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-01-12 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:30 [PATCH] net: Remove redundant NAPI functions Ben Hutchings
2009-01-08 20:40 ` Joe Perches
2009-01-08 20:54 ` David Miller
2009-01-09 14:58 ` Neil Horman
2009-01-10 7:06 ` David Miller
2009-01-12 7:13 ` Jarek Poplawski
2009-01-12 14:09 ` Ben Hutchings [this message]
2009-01-12 14:46 ` Ben Hutchings
2009-01-12 17:31 ` Krzysztof Halasa
2009-01-13 0:30 ` David Miller
2009-01-13 1:35 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231769390.3075.2.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.