From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kewei@marvell.com
Cc: linux-scsi@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
djwong@us.ibm.com, Jason Chu <jasonchu@marvell.com>,
Michael Wang <qswang@marvell.com>, Jacky Feng <jfeng@marvell.com>
Subject: Re: [PATCH] libsas: User mode app failed to send ioctl commands to SATA drive.
Date: Mon, 12 Jan 2009 09:33:46 -0600 [thread overview]
Message-ID: <1231774426.3256.2.camel@localhost.localdomain> (raw)
In-Reply-To: <496B1B31.4050606@marvell.com>
On Mon, 2009-01-12 at 18:28 +0800, Ke Wei wrote:
> The context of scsi_host's hostdata points to a sas ha structure with libsas
> module, but the libata casts this pointer to a ata_port structure when ioctl
> sends HDIO_GET_IDENTITY.
This is a good find thanks. I think there's a small problem in the way
the layering is done.
I think ata_scsi_ioctl needs to be expanded to pass the port in all the
time. That way other implementors don't have to remember to special
case HDIO_GET_IDENTITY.
When you redo this, ipr will need altering as well (rather than also
having the identity exception added).
James
next prev parent reply other threads:[~2009-01-12 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 10:28 [PATCH] libsas: User mode app failed to send ioctl commands to SATA drive Ke Wei
2009-01-12 15:33 ` James Bottomley [this message]
2009-01-16 12:20 ` Jeff Garzik
2009-01-16 14:21 ` James Bottomley
2009-01-16 14:33 ` Jeff Garzik
2009-01-20 20:18 ` problems resuming with some SATA drives Stuart_Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231774426.3256.2.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=djwong@us.ibm.com \
--cc=jasonchu@marvell.com \
--cc=jeff@garzik.org \
--cc=jfeng@marvell.com \
--cc=kewei@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=qswang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.