From: Pavel Roskin <proski@gnu.org>
To: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: checkpatch confused by pre-existing #endif
Date: Tue, 13 Jan 2009 16:57:43 -0500 [thread overview]
Message-ID: <1231883863.21706.17.camel@dv> (raw)
Hello!
This patch confuses checkpatch.pl from Linux 2.6.29-rc1:
====================
--- foo.h.old 2009-01-13 16:48:22.000000000 -0500
+++ foo.h 2009-01-13 16:48:18.000000000 -0500
@@ -3,4 +3,8 @@
+#ifdef FOOBAR
+#define foo
+#endif
+
#endif /* FOO_H */
====================
$ scripts/checkpatch.pl foo.diff
Can't use an undefined value as an ARRAY reference at
scripts/checkpatch.pl line 453.
Apparently, the last #endif causes some data to be popped from the stack
for preprocessor directives. However, the corresponding #ifdef is
outside the patch, so this fails.
--
Regards,
Pavel Roskin
next reply other threads:[~2009-01-13 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 21:57 Pavel Roskin [this message]
2009-01-14 16:45 ` checkpatch confused by pre-existing #endif Andy Whitcroft
2009-01-14 16:49 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231883863.21706.17.camel@dv \
--to=proski@gnu.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.