All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
To: linux-mips@linux-mips.org
Subject: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial
Date: Wed, 14 Jan 2009 16:35:42 +0200	[thread overview]
Message-ID: <1231943742.8457.6.camel@EPBYMINW0568> (raw)

I think that's a better solution for the problem I said so please commit
this patch rather previous one...

---

Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
serial. Rather create ttyPNX[0-1]. Also changed minor number to be
different with sa1100 serial driver one.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
---
 drivers/serial/pnx8xxx_uart.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
index 22e30d2..96870f1 100644
--- a/drivers/serial/pnx8xxx_uart.c
+++ b/drivers/serial/pnx8xxx_uart.c
@@ -34,9 +34,8 @@
 #include <asm/io.h>
 #include <asm/irq.h>
 
-/* We'll be using StrongARM sa1100 serial port major/minor */
 #define SERIAL_PNX8XXX_MAJOR	204
-#define MINOR_START		5
+#define MINOR_START		96
 
 #define NR_PORTS		2
 
@@ -636,7 +635,7 @@ static struct uart_ops pnx8xxx_pops = {
 /*
  * Setup the PNX8XXX serial ports.
  *
- * Note also that we support "console=ttySx" where "x" is either 0 or 1.
+ * Note also that we support "console=ttyPNXx" where "x" is either 0 or 1.
  */
 static void __init pnx8xxx_init_ports(void)
 {
@@ -728,7 +727,7 @@ pnx8xxx_console_setup(struct console *co, char *options)
 
 static struct uart_driver pnx8xxx_reg;
 static struct console pnx8xxx_console = {
-	.name		= "ttyS",
+	.name		= "ttyPNX",
 	.write		= pnx8xxx_console_write,
 	.device		= uart_console_device,
 	.setup		= pnx8xxx_console_setup,
@@ -752,8 +751,8 @@ console_initcall(pnx8xxx_rs_console_init);
 
 static struct uart_driver pnx8xxx_reg = {
 	.owner			= THIS_MODULE,
-	.driver_name		= "ttyS",
-	.dev_name		= "ttyS",
+	.driver_name		= "ttyPNX",
+	.dev_name		= "ttyPNX",
 	.major			= SERIAL_PNX8XXX_MAJOR,
 	.minor			= MINOR_START,
 	.nr			= NR_PORTS,
-- 
1.5.6.3

             reply	other threads:[~2009-01-14 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 14:35 Ihar Hrachyshka [this message]
2009-01-14 22:04 ` [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial Sergei Shtylyov
2009-01-14 22:20   ` Ihar Hrachyshka
2009-01-14 22:20     ` Ihar Hrachyshka
  -- strict thread matches above, loose matches on Subject: below --
2009-01-14 13:55 Ihar Hrachyshka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231943742.8457.6.camel@EPBYMINW0568 \
    --to=ihar.hrachyshka@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.