Re: [PATCH 1/4] virtio_net: Allow setting the MAC address of the NIC

[Alex Williamson <alex.williamson@hp.com>]

On Wed, 2009-01-14 at 10:15 +0000, Mark McLoughlin wrote:
> On Tue, 2009-01-13 at 14:23 -0700, Alex Williamson wrote:
> 
> Commit log explaining why we need this.

Sorry, my commit logs are pretty weak across the board.  I'll update
them all.

> > +	} else {
> >  		random_ether_addr(dev->dev_addr);
> > +		vdev->config->set(vdev, offsetof(struct virtio_net_config, mac),
> > +				  dev->dev_addr, dev->addr_len);
> > +	}
> 
> Please make sure you test this with a host which doesn't set a default
> mac address, otherwise it's "untested buggy code" :-)

Good idea, I'll hack the backend to not advertise that feature and make
sure this code gets exercised a least once.  Thanks,

Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.