From: Mark McLoughlin <markmc@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, kvm <kvm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] virtio_net: Add a MAC filter table
Date: Wed, 14 Jan 2009 16:38:56 +0000 [thread overview]
Message-ID: <1231951136.4944.305.camel@localhost.localdomain> (raw)
In-Reply-To: <1231950031.7109.307.camel@lappy>
On Wed, 2009-01-14 at 09:20 -0700, Alex Williamson wrote:
> > Also, no need for the extra variable or the case, is there?
>
> Initially, that's what I thought too... but it doesn't work, I always
> got 0 on the backend. I assume it has something to do with the memory
> segment mac_entries lives in as a static variable.
Bizarre - it'd be good to understand exactly why. Add a comment to that
effect, at least.
Cheers,
Mark.
prev parent reply other threads:[~2009-01-14 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 21:23 [PATCH 4/4] virtio_net: Add a MAC filter table Alex Williamson
2009-01-14 10:15 ` Mark McLoughlin
2009-01-14 16:20 ` Alex Williamson
2009-01-14 16:38 ` Mark McLoughlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231951136.4944.305.camel@localhost.localdomain \
--to=markmc@redhat.com \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.