From: Ben Hutchings <bhutchings@solarflare.com>
To: Eilon Greenstein <eilong@broadcom.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO
Date: Wed, 14 Jan 2009 18:00:21 +0000 [thread overview]
Message-ID: <1231956021.3010.35.camel@achroite> (raw)
In-Reply-To: <1231954948.11301.158.camel@lb-tlvb-eliezer>
On Wed, 2009-01-14 at 19:42 +0200, Eilon Greenstein wrote:
> On Wed, 2009-01-14 at 08:57 -0800, Ben Hutchings wrote:
> > On Wed, 2009-01-14 at 18:42 +0200, Eilon Greenstein wrote:
> > > When TPA (HW GRO) is used, the GSO_TYPE should be set
> > [...]
> >
> > No it shouldn't. That is for the output path only.
> >
>
> Right - but it was an issue with forwarding
You can't use LRO together with forwarding/bridging unless you replicate
what Herbert Xu has done to allow reconstruction of the original frames.
Setting gso_type is a hack which you may or may not get away with,
depending on the output device's capabilities.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-01-14 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:42 [PATCH 05/34]bnx2x: Setting the GSO_TYPE with LRO Eilon Greenstein
2009-01-14 16:57 ` Ben Hutchings
2009-01-14 17:42 ` Eilon Greenstein
2009-01-14 18:00 ` Ben Hutchings [this message]
2009-01-14 19:29 ` Eilon Greenstein
2009-01-14 20:18 ` Herbert Xu
2009-01-14 20:27 ` Ben Hutchings
2009-01-14 21:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231956021.3010.35.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.