All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Mark Glines <mark@glines.org>
Cc: Ingo Molnar <mingo@elte.hu>, L-K <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.28 has unconfigurable group sched?
Date: Thu, 15 Jan 2009 08:29:04 +0100	[thread overview]
Message-ID: <1232004544.14825.75.camel@laptop> (raw)
In-Reply-To: <496DFACE.10403@glines.org>

On Wed, 2009-01-14 at 06:46 -0800, Mark Glines wrote:
> Peter Zijlstra wrote:
> >> So it seems rt_schedulable() is never succeeding.  Any ideas?
> > 
> > Yeah, I should test this user grouping stuff more often :/
> > 
> > The below fixes it for me.
> > ---
> > Subject: sched: fix bandwidth validation for UID grouping 
> > 
> > For UID grouping we initialize the root group with infinite bandwidth
> > which by default is actually more than the global limit, therefore the
> > bandwidth check always fails.
> > 
> > Because the root group is a phantom group (for UID grouping) we cannot
> > runtime adjust it, therefore we let it reflect the global bandwidth
> > settings.
> 
> 
> Thanks.  Sadly, this doesn't seem to change anything for me.  I applied
> it to 2.6.28, rebuilt and reinstalled, and got the same result.  I did a
> clean rebuild to be sure; and got the same behavior again.
> 
> Please let me know if there are any additional diagnostics I can provide.

Most strange, I did the patch on .28 just to be sure (my initial testing
was done on -linus since I couldn't remember it having changed in a
while), and it still works for me.

CONFIG_GROUP_SCHED=y
CONFIG_FAIR_GROUP_SCHED=y
CONFIG_RT_GROUP_SCHED=y
CONFIG_USER_SCHED=y
# CONFIG_CGROUP_SCHED is not set

Linux opteron 2.6.28 #634 SMP PREEMPT Wed Jan 14 18:13:31 CET 2009
x86_64 x86_64 x86_64 GNU/Linux

# echo 450000 > /sys/kernel/uids/0/cpu_rt_runtime 
# cat /sys/kernel/uids/0/cpu_rt_runtime
450000



  reply	other threads:[~2009-01-15  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 18:31 2.6.28 has unconfigurable group sched? Mark Glines
2009-01-14  9:56 ` Peter Zijlstra
2009-01-14 14:46   ` Mark Glines
2009-01-15  7:29     ` Peter Zijlstra [this message]
2009-01-15 16:00       ` Mark Glines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232004544.14825.75.camel@laptop \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@glines.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.