All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Mike Galbraith <efault@gmx.de>,
	"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	dev@jaysonking.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Performance regression of specjbb2005/aim7 with 2.6.29-rc1
Date: Thu, 15 Jan 2009 16:10:58 +0100	[thread overview]
Message-ID: <1232032258.8870.71.camel@laptop> (raw)
In-Reply-To: <1231986636.10565.159.camel@minggr.sh.intel.com>

On Thu, 2009-01-15 at 10:30 +0800, Lin Ming wrote:

> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index 8e1352c..617e54c 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -429,10 +429,10 @@ static u64 sched_slice(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  	u64 slice = __sched_period(cfs_rq->nr_running + !se->on_rq);
>  
>  	for_each_sched_entity(se) {
> -		struct load_weight *load = &cfs_rq->load;
> +		struct load_weight *load = &cfs_rq_of(se)->load;
>  
>  		if (unlikely(!se->on_rq)) {
> -			struct load_weight lw = cfs_rq->load;
> +			struct load_weight lw = cfs_rq_of(se)->load;
>  
>  			update_load_add(&lw, se->load.weight);
>  			load = &lw;
> 

I was wrong, this does look good.

Thanks


  parent reply	other threads:[~2009-01-15 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13  8:57 Performance regression of specjbb2005/aim7 with 2.6.29-rc1 Zhang, Yanmin
2009-01-13  9:37 ` Mike Galbraith
2009-01-15  2:30   ` Lin Ming
2009-01-15  7:36     ` Peter Zijlstra
2009-01-15 15:10     ` Peter Zijlstra [this message]
2009-01-15 16:17     ` Peter Zijlstra
2009-01-15 17:54       ` Ingo Molnar
2009-01-15 18:53       ` Jayson King
2009-01-15 20:09         ` Ingo Molnar
2009-01-16  0:49       ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232032258.8870.71.camel@laptop \
    --to=peterz@infradead.org \
    --cc=dev@jaysonking.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.