From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 29/35] Btrfs ioctl code
Date: Thu, 15 Jan 2009 15:28:22 -0500
Message-ID: <1232051302.8269.99.camel@think.oraclecorp.com>
References: <1231387045-27838-1-git-send-email-chris.mason@oracle.com>
	 <1231387045-27838-30-git-send-email-chris.mason@oracle.com>
	 <20090116.032900.03617624.ryusuke@osrg.net>
	 <alpine.LFD.2.00.0901151215130.6528@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
	akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from acsinet12.oracle.com ([141.146.126.234]:16614 "EHLO
	acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1765817AbZAOU3T (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 15 Jan 2009 15:29:19 -0500
In-Reply-To: <alpine.LFD.2.00.0901151215130.6528@localhost.localdomain>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2009-01-15 at 12:17 -0800, Linus Torvalds wrote:
> 
> On Fri, 16 Jan 2009, Ryusuke Konishi wrote:
> 
> > Hi Chris,
> > On Wed,  7 Jan 2009 22:57:19 -0500, Chris Mason wrote:
> > > +
> > > +struct btrfs_ioctl_vol_args {
> > > +	__s64 fd;
> > > +	char name[BTRFS_PATH_NAME_MAX + 1];
> > > +};
> > 
> > The size of btrfs_ioctl_vol_args seems to depend on architectures.
> > 
> > For example, the size was 3084 bytes on a x86-32 machine, but was 3088
> > bytes on a x86-64 machine.
> 
> Grr. Different alignment for 64-bit values, coupled with "name" not 
> having a size that is a multiple-of-eight.
> 

Will the fd and the start of the name get aligned differently?  I'll fix
it up

-chris