From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings
Date: Mon, 19 Jan 2009 07:46:05 +0530 [thread overview]
Message-ID: <1232331365.3129.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20090118190836.GA2294@uranus.ravnborg.org>
On Sun, 2009-01-18 at 20:08 +0100, Sam Ravnborg wrote:
> >
> > diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h
> > index 306d417..613be68 100644
> > --- a/arch/x86/include/asm/swab.h
> > +++ b/arch/x86/include/asm/swab.h
> > @@ -1,12 +1,15 @@
> > #ifndef _ASM_X86_SWAB_H
> > #define _ASM_X86_SWAB_H
> >
> > -#include <asm/types.h>
> > +#include <linux/types.h>
> > +#ifdef __KERNEL__
> > #include <linux/compiler.h>
> > +#endif /* __KERNEL__ */
>
> compiler.h includes should be nuked by make headers_instll automatically.
>
But the problem is compiler.h provide extra line space in userspace
header files because of nuking them.
So I moved compiler.h in __KERNEL__ as extra cleanup, it is not harmful
but looks much nicer in userspace header files
--
JSR
next prev parent reply other threads:[~2009-01-19 2:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 14:04 [GIT PULL -tip v3] fix 39 'make headers_check' warnings Jaswinder Singh Rajput
2009-01-18 17:28 ` Ingo Molnar
2009-01-18 18:50 ` Ingo Molnar
2009-01-18 18:52 ` Ingo Molnar
2009-01-18 19:08 ` Sam Ravnborg
2009-01-18 19:09 ` Ingo Molnar
2009-01-18 19:45 ` Sam Ravnborg
2009-01-19 2:16 ` Jaswinder Singh Rajput [this message]
2009-01-19 5:27 ` Sam Ravnborg
2009-01-19 2:10 ` Jaswinder Singh Rajput
2009-01-19 2:20 ` Harvey Harrison
2009-01-19 11:15 ` Ingo Molnar
2009-01-19 18:08 ` Harvey Harrison
2009-01-18 18:56 ` Ingo Molnar
2009-01-19 9:19 ` Avi Kivity
2009-01-19 11:01 ` Sam Ravnborg
2009-01-19 11:53 ` Avi Kivity
2009-01-24 6:16 ` Jaswinder Singh Rajput
2009-02-04 14:28 ` Avi Kivity
2009-02-04 15:17 ` Jaswinder Singh Rajput
2009-02-04 15:40 ` Avi Kivity
2009-02-04 16:00 ` Jaswinder Singh Rajput
2009-02-04 16:37 ` Arnd Bergmann
2009-02-04 17:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232331365.3129.7.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.