From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL -tip] fix 41 'make headers_check' warnings
Date: Mon, 19 Jan 2009 08:01:14 +0530 [thread overview]
Message-ID: <1232332274.3129.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20090119105324.fd4e9084.sfr@canb.auug.org.au>
On Mon, 2009-01-19 at 10:53 +1100, Stephen Rothwell wrote:
> Hi Jaswinder,
>
> On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
> > index 04b4d73..277de8c 100644
> > --- a/include/linux/pktcdvd.h
> > +++ b/include/linux/pktcdvd.h
> > @@ -33,11 +33,15 @@
> > * able to sucessfully recover with this option (drive will return good
> > * status as soon as the cdb is validated).
> > */
> > +#ifdef __KERNEL__
> > #if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
> > #define USE_WCACHING 1
> > #else
> > #define USE_WCACHING 0
> > #endif
> > +#else /* __KERNEL__ */
> > +#define USE_WCACHING 0
> > +#endif /* __KERNEL__ */
>
> This also only has one user (drivers/block/pktcdvd.c) so maybe it should
> be moved there.
>
Already fixed in v3 as pointed by Ingo.
Thanks,
--
JSR
next prev parent reply other threads:[~2009-01-19 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 10:10 [GIT PULL -tip] fix 41 'make headers_check' warnings Jaswinder Singh Rajput
2009-01-18 11:02 ` Ingo Molnar
2009-01-18 11:26 ` Jaswinder Singh Rajput
2009-01-18 12:26 ` Ingo Molnar
2009-01-18 12:57 ` Sam Ravnborg
2009-01-18 13:00 ` Sam Ravnborg
2009-01-18 17:29 ` Ingo Molnar
2009-01-21 0:58 ` Jaswinder Singh Rajput
2009-01-21 1:27 ` Jaswinder Singh Rajput
2009-01-21 5:53 ` Size of sector_t in userspace [Was: fix 41 'make headers_check' warnings] Sam Ravnborg
2009-01-21 8:21 ` Jens Axboe
2009-01-21 11:34 ` Sam Ravnborg
2009-01-18 22:39 ` [GIT PULL -tip] fix 41 'make headers_check' warnings Stephen Rothwell
2009-01-19 1:20 ` Sam Ravnborg
2009-01-18 22:50 ` Stephen Rothwell
2009-01-19 2:30 ` Jaswinder Singh Rajput
2009-01-19 3:53 ` Stephen Rothwell
2009-01-18 23:53 ` Stephen Rothwell
2009-01-19 2:31 ` Jaswinder Singh Rajput [this message]
2009-01-19 3:48 ` Stephen Rothwell
2009-01-19 5:16 ` Jaswinder Singh Rajput
2009-01-18 23:59 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232332274.3129.9.camel@localhost.localdomain \
--to=jaswinder@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.