From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: ioremap()/iounmap() problem
Date: Mon, 19 Jan 2009 14:27:34 +0200 [thread overview]
Message-ID: <1232368054.6481.110.camel@tubuntu> (raw)
In-Reply-To: <20090119110116.GA15007@n2100.arm.linux.org.uk>
Hi,
On Mon, 2009-01-19 at 11:01 +0000, ext Russell King - ARM Linux wrote:
> On Mon, Jan 19, 2009 at 12:23:03PM +0200, Tomi Valkeinen wrote:
> > Hi,
> >
> > Running with latest linux-omap kernel on OMAP3 SDP board, I have problem
> > with iounmap(). It looks like iounmap() does not properly free large
> > areas. Below is a test which fails for me in 6-7 loops.
> >
> > OMAP spesific ioremap code doesn't do much, so I think it's somewhere in
> > generic ARM code. I looked at the ioremap code and for larger areas the
> > code uses area sections, and I believe the bug is somewhere there.
>
> In unmap_area_sections(), try changing:
>
> unsigned long addr = virt, end = virt + (size & ~SZ_1M);
>
> to
>
> unsigned long addr = virt, end = virt + (size & ~(SZ_1M - 1));
This didn't help. I Added two debug prints, not sure if it means
anything but the size on the second unmap is not the same as in the
previous ones.
remap_area_sections(virt=d2000000, size=1000000, end=d3000000, pfn=70000)
unmap_area_sections(virt=d2000000, size=1000000, end=d3000000)
ioremapped to d2000000
unmap_area_sections(virt=d2000000, size=1001000, end=d3000000)
Tomi
next prev parent reply other threads:[~2009-01-19 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 10:23 ioremap()/iounmap() problem Tomi Valkeinen
2009-01-19 11:01 ` Russell King - ARM Linux
2009-01-19 12:27 ` Tomi Valkeinen [this message]
2009-01-19 12:53 ` Russell King - ARM Linux
2009-01-19 13:49 ` Tomi Valkeinen
2009-01-21 19:23 ` Russell King - ARM Linux
2009-01-22 11:55 ` Tomi Valkeinen
2009-01-22 15:25 ` Matt Gerassimoff
2009-01-19 13:34 ` Woodruff, Richard
2009-01-19 13:43 ` Russell King - ARM Linux
2009-01-19 13:48 ` Woodruff, Richard
2009-01-19 13:56 ` Russell King - ARM Linux
2009-01-19 15:06 ` Matt Gerassimoff
2009-01-19 15:22 ` Russell King - ARM Linux
2009-01-19 15:39 ` Matt Gerassimoff
2009-01-19 15:58 ` Russell King - ARM Linux
2009-01-19 16:13 ` Russell King - ARM Linux
2009-01-19 17:07 ` Matt Gerassimoff
2009-01-19 17:14 ` Russell King - ARM Linux
2009-01-19 17:47 ` Matt Gerassimoff
2009-01-19 17:07 ` Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232368054.6481.110.camel@tubuntu \
--to=tomi.valkeinen@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.