All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Calvin Walton <calvin.walton@gmail.com>
Cc: Peter Klotz <peter.klotz@aon.at>, linux-btrfs@vger.kernel.org
Subject: Re: Misleading error message in btrfsctl
Date: Wed, 21 Jan 2009 10:05:29 -0500	[thread overview]
Message-ID: <1232550329.17244.8.camel@think.oraclecorp.com> (raw)
In-Reply-To: <1232287950.10058.6.camel@trillian>

On Sun, 2009-01-18 at 09:12 -0500, Calvin Walton wrote:
> On Sun, 2009-01-18 at 14:40 +0100, Peter Klotz wrote:
> > Calling btrfsctl results in this message when module btrfs.ko is not loaded:
> > 
> > root@asus:/root# btrfsctl -A /dev/sda
> > ioctl:: Bad file descriptor
> ..
> > The output with applied patch:
> > 
> > root@asus:/root# btrfsctl -A /dev/sda
> > failed to open /dev/btrfs-control
> 
> It would probably be better to use perror() instead of fprintf, in order
> to give the actual error message. I often find it useful to know why the
> device failed to open - is it missing, permission issues? I've updated
> the patch:
> 

Thanks

-chris



      reply	other threads:[~2009-01-21 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 13:40 Misleading error message in btrfsctl Peter Klotz
2009-01-18 14:12 ` Calvin Walton
2009-01-21 15:05   ` Chris Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232550329.17244.8.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=calvin.walton@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=peter.klotz@aon.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.