From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LPgux-00086J-Vl for mharc-grub-devel@gnu.org; Wed, 21 Jan 2009 12:31:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPguv-00084Q-Q3 for grub-devel@gnu.org; Wed, 21 Jan 2009 12:31:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPgut-00081g-5M for grub-devel@gnu.org; Wed, 21 Jan 2009 12:31:04 -0500 Received: from [199.232.76.173] (port=51236 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPgus-00081T-NX for grub-devel@gnu.org; Wed, 21 Jan 2009 12:31:02 -0500 Received: from c60.cesmail.net ([216.154.195.49]:4562) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LPgus-00072W-Eh for grub-devel@gnu.org; Wed, 21 Jan 2009 12:31:02 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 21 Jan 2009 12:30:59 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 0A08434C6A for ; Wed, 21 Jan 2009 12:44:41 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <49771040.7010509@impulze.org> References: <49771040.7010509@impulze.org> Content-Type: text/plain Date: Wed, 21 Jan 2009 12:30:57 -0500 Message-Id: <1232559057.17462.2.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 17:31:06 -0000 On Wed, 2009-01-21 at 13:08 +0100, Daniel Mierswa wrote: > Hi list, > during testing I found that the UUID is checked case-dependend in > search.c, which is probably not wanted (I hope). > Also the grub_strncasecmp function returned (int) *s1 - (int) *s2 which > is wrong if you compare it to the C library strncasecmp. I agree, that's definitely wrong. Good catch! > I fixed that and used the same algorithm which is used in grub_strncmp > (Taking a grub_size_t instead of int and checked the decremented value > in the loop). I also added strcasecmp for consistency reasons which is > used by search.c now. > I'd appreciate your your replies. The patch looks good to me. I would split changes to commands/search.c into a separate commit. Please provide ChangeLog entries for the patches. -- Regards, Pavel Roskin