From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758906AbZAWRlJ (ORCPT ); Fri, 23 Jan 2009 12:41:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755591AbZAWRkz (ORCPT ); Fri, 23 Jan 2009 12:40:55 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:45813 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754851AbZAWRky (ORCPT ); Fri, 23 Jan 2009 12:40:54 -0500 Subject: Re: [PATCH] x86,mm: fix pte_free() From: Peter Zijlstra To: Ingo Molnar Cc: Linus Torvalds , Nick Piggin , Hugh Dickins , Thomas Gleixner , Andrew Morton , L-K , linux-mm , David Howells In-Reply-To: <20090123173421.GA30980@elte.hu> References: <1232728669.4826.143.camel@laptop> <20090123173421.GA30980@elte.hu> Content-Type: text/plain Date: Fri, 23 Jan 2009 18:39:46 +0100 Message-Id: <1232732387.4850.1.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-01-23 at 18:34 +0100, Ingo Molnar wrote: > So i agree with the fix, but the patch does not look right: shouldnt that > be pgtable_page_dtor(pte), so that we get ->mapping cleared via > pte_lock_deinit()? (which i guess your intention was here - this probably > wont even build) Yeah, I somehow fudged it, already send out a better one. -- One of them days I guess :-( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id B33626B0085 for ; Fri, 23 Jan 2009 12:39:52 -0500 (EST) Subject: Re: [PATCH] x86,mm: fix pte_free() From: Peter Zijlstra In-Reply-To: <20090123173421.GA30980@elte.hu> References: <1232728669.4826.143.camel@laptop> <20090123173421.GA30980@elte.hu> Content-Type: text/plain Date: Fri, 23 Jan 2009 18:39:46 +0100 Message-Id: <1232732387.4850.1.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Ingo Molnar Cc: Linus Torvalds , Nick Piggin , Hugh Dickins , Thomas Gleixner , Andrew Morton , L-K , linux-mm , David Howells List-ID: On Fri, 2009-01-23 at 18:34 +0100, Ingo Molnar wrote: > So i agree with the fix, but the patch does not look right: shouldnt that > be pgtable_page_dtor(pte), so that we get ->mapping cleared via > pte_lock_deinit()? (which i guess your intention was here - this probably > wont even build) Yeah, I somehow fudged it, already send out a better one. -- One of them days I guess :-( -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org