From: reinette chatre <reinette.chatre@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
"Abbas, Mohamed" <mohamed.abbas@intel.com>
Subject: Re: [PATCH 2/2 v2.6.29] iwlagn: fix agn rate scaling
Date: Fri, 23 Jan 2009 11:28:57 -0800 [thread overview]
Message-ID: <1232738937.24871.6.camel@rc-desk> (raw)
In-Reply-To: <20090123190138.GC30486@tuxdriver.com>
On Fri, 2009-01-23 at 11:01 -0800, John W. Linville wrote:
> On Wed, Jan 21, 2009 at 10:58:03AM -0800, Reinette Chatre wrote:
> > From: Abbas, Mohamed <mohamed.abbas@intel.com>
> >
> > Sometime Tx reply rate different than what rate scale expecting
> > causing rate scale to bail out. This could cause failing to
> > commit LQ cmd. This patch will try to solve this instead of just
> > bail out. It also make sure we start with a valid rate.
> >
> > Signed-off-by: mohamed abbas <mohamed.abbas@intel.com>
> > Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
>
> While I'm sure this would be nice to fix, I don't see the regression,
> Oops or crash?
You are right - this does not fix an oops or a crash. Having this patch
in 2.6.29 is thus not critical.
Reinette
next prev parent reply other threads:[~2009-01-23 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 18:58 [PATCH 0/2 v2.6.29] iwlwifi driver fixes for 2.6.29 Reinette Chatre
2009-01-21 18:58 ` [PATCH 1/2 v2.6.29] iwlwifi: fix rs_get_rate WARN_ON() Reinette Chatre
2009-01-21 18:58 ` [PATCH 2/2 v2.6.29] iwlagn: fix agn rate scaling Reinette Chatre
2009-01-23 19:01 ` John W. Linville
2009-01-23 19:28 ` reinette chatre [this message]
2009-01-23 19:55 ` [ipw3945-devel] " Tomas Winkler
2009-01-23 20:01 ` John W. Linville
2009-01-22 10:57 ` [PATCH 1/2 v2.6.29] iwlwifi: fix rs_get_rate WARN_ON() Johannes Berg
2009-01-22 16:51 ` Abbas, Mohamed
2009-01-25 16:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232738937.24871.6.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mohamed.abbas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.