From: Eric Anholt <eric@anholt.net>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Work around PAGE_KERNEL_WC not getting WC in iomap_atomic_prot_pfn.
Date: Fri, 23 Jan 2009 15:29:43 -0800 [thread overview]
Message-ID: <1232753383.4749.2.camel@gaiman> (raw)
In-Reply-To: <adamydh1uo0.fsf@cisco.com>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Fri, 2009-01-23 at 15:15 -0800, Roland Dreier wrote:
> > + if (!pat_enabled && pgprot_val(prot) == pgprot_val(PAGE_KERNEL_WC))
> > + prot = PAGE_KERNEL_UC_MINUS;
>
> indentation broke here (the "prot =" line is indented with a tab then
> two spaces, instead of two tabs)
Bad path matching going on in my .emacs indentation setup. I don't get
out of the DRM driver often enough. Or rather, I'm in nasty X code too
often :)
Fixed this and the other nitpick. Thanks!
--
Eric Anholt
eric@anholt.net eric.anholt@intel.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-23 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 22:54 [PATCH] drm/i915: Set up an MTRR covering the GTT at driver load Eric Anholt
2009-01-23 22:54 ` [PATCH] x86: Work around PAGE_KERNEL_WC not getting WC in iomap_atomic_prot_pfn Eric Anholt
2009-01-23 23:15 ` Roland Dreier
2009-01-23 23:29 ` Eric Anholt [this message]
2009-01-23 23:13 ` [PATCH] drm/i915: Set up an MTRR covering the GTT at driver load Roland Dreier
2009-01-24 11:51 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232753383.4749.2.camel@gaiman \
--to=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.